[all-commits] [llvm/llvm-project] 5e9937: [libc][math] Adds entrypoint and tests for nearbyi...

Michael Flanders via All-commits all-commits at lists.llvm.org
Mon Apr 29 16:26:07 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5e9937d1b3ada9c686505c5f2c1e1b054ad9edc2
      https://github.com/llvm/llvm-project/commit/5e9937d1b3ada9c686505c5f2c1e1b054ad9edc2
  Author: Michael Flanders <flanders.michaelk at gmail.com>
  Date:   2024-04-29 (Mon, 29 Apr 2024)

  Changed paths:
    M libc/config/linux/aarch64/entrypoints.txt
    M libc/config/linux/riscv/entrypoints.txt
    M libc/config/linux/x86_64/entrypoints.txt
    M libc/docs/math/index.rst
    M libc/spec/stdc.td
    M libc/src/math/CMakeLists.txt
    M libc/src/math/generic/CMakeLists.txt
    A libc/src/math/generic/nearbyintf128.cpp
    A libc/src/math/generic/scalbnf128.cpp
    A libc/src/math/nearbyintf128.h
    A libc/src/math/scalbnf128.h
    M libc/test/UnitTest/FPMatcher.h
    M libc/test/src/math/CMakeLists.txt
    A libc/test/src/math/scalbnf128_test.cpp
    M libc/test/src/math/smoke/CMakeLists.txt
    A libc/test/src/math/smoke/NearbyIntTest.h
    A libc/test/src/math/smoke/nearbyint_test.cpp
    A libc/test/src/math/smoke/nearbyintf128_test.cpp
    A libc/test/src/math/smoke/nearbyintf_test.cpp
    A libc/test/src/math/smoke/nearbyintl_test.cpp
    A libc/test/src/math/smoke/scalbnf128_test.cpp

  Log Message:
  -----------
  [libc][math] Adds entrypoint and tests for nearbyintf128,scalbnf128 (#88443)

Closes #84689.

Adding @lntue for review.

I was curious about the implementation of
`round_using_current_rounding_mode` used for the `nearbyint` functions.
It has one of the rounding modes as unreachable
([here](https://github.com/llvm/llvm-project/blob/main/libc/src/__support/FPUtil/NearestIntegerOperations.h#L243)),
and I was wondering if this was okay for the `nearbyint` functions.

---------

Co-authored-by: Michael Flanders <mkf727 at cs.washington.edu>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list