[all-commits] [llvm/llvm-project] f1112e: AMDGPU: Do not bitcast atomic load in IR (#90060)

Matt Arsenault via All-commits all-commits at lists.llvm.org
Fri Apr 26 03:21:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1112ebe074ea098d83dd100e67c218e1a20adf9
      https://github.com/llvm/llvm-project/commit/f1112ebe074ea098d83dd100e67c218e1a20adf9
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
    M llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
    M llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
    M llvm/test/Transforms/AtomicExpand/AMDGPU/no-expand-atomic-load.ll

  Log Message:
  -----------
  AMDGPU: Do not bitcast atomic load in IR (#90060)

These hooks should be removed. This is a trivial legalization transform
the legalizer needs to support. The IR just complicates things, and it
was losing metadata. Implement the DAG promotion support, and switch
AMDGPU over to using it.

Really we'd be a lot better off merging ATOMIC_LOAD and LOAD like
GlobalISel does.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list