[all-commits] [llvm/llvm-project] 74a5e7: [llvm-exegesis] Close file descriptors after use (...

[Aiden Grossman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 74a5e7784b32aba5670ff427b158d1e6e38012f1
      https://github.com/llvm/llvm-project/commit/74a5e7784b32aba5670ff427b158d1e6e38012f1
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2024-04-26 (Fri, 26 Apr 2024)

  Changed paths:
    M llvm/tools/llvm-exegesis/lib/BenchmarkRunner.cpp
    M llvm/tools/llvm-exegesis/lib/SubprocessMemory.cpp

  Log Message:
  -----------
  [llvm-exegesis] Close file descriptors after use (#86584)

There are several insstances in the subprocess executor in llvm-exegesis
where we fail to close file descriptors after using them. This leaves
them open, which can cause issues later on if a third-party binary is
using the exegesis libraries and executing many blocks before exiting.
Leaving the descriptors open until process exit is also bad practice.
This patch fixes that by explicitly calling close() when we are done
with a specific file descriptor.

This patch fixes #86583.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications