[all-commits] [llvm/llvm-project] 577948: [lldb][nfc] Move broadcaster class strings away fr...

[Alex Langford via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 57794835279669358ff2828d659eb7133fc0e4bf
      https://github.com/llvm/llvm-project/commit/57794835279669358ff2828d659eb7133fc0e4bf
  Author: Alex Langford <alangford at apple.com>
  Date:   2024-04-24 (Wed, 24 Apr 2024)

  Changed paths:
    M lldb/include/lldb/Core/Debugger.h
    M lldb/include/lldb/Core/ThreadedCommunication.h
    M lldb/include/lldb/Interpreter/CommandInterpreter.h
    M lldb/include/lldb/Target/Process.h
    M lldb/include/lldb/Target/Target.h
    M lldb/include/lldb/Target/TargetList.h
    M lldb/include/lldb/Target/Thread.h
    M lldb/include/lldb/Utility/Broadcaster.h
    M lldb/source/API/SBCommandInterpreter.cpp
    M lldb/source/API/SBCommunication.cpp
    M lldb/source/API/SBDebugger.cpp
    M lldb/source/API/SBEvent.cpp
    M lldb/source/API/SBProcess.cpp
    M lldb/source/API/SBTarget.cpp
    M lldb/source/API/SBThread.cpp
    M lldb/source/Core/Debugger.cpp
    M lldb/source/Core/ThreadedCommunication.cpp
    M lldb/source/Interpreter/CommandInterpreter.cpp
    M lldb/source/Target/Process.cpp
    M lldb/source/Target/Target.cpp
    M lldb/source/Target/TargetList.cpp
    M lldb/source/Target/Thread.cpp
    M lldb/source/Utility/Broadcaster.cpp

  Log Message:
  -----------
  [lldb][nfc] Move broadcaster class strings away from ConstString (#89690)

These are hardcoded strings that are already present in the data section
of the binary, no need to immediately place them in the ConstString
StringPools. Lots of code still calls `GetBroadcasterClass` and places
the return value into a ConstString. Changing that would be a good
follow-up.

Additionally, calls to these functions are still wrapped in ConstStrings
at the SBAPI layer. This is because we must guarantee the lifetime of
all strings handed out publicly.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications