[all-commits] [llvm/llvm-project] 033611: [libc][docs] codify Policy on Assembler Sources (#...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Mon Apr 22 11:57:50 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0336116ed463c2ad125793a5aa4d7290a2155709
      https://github.com/llvm/llvm-project/commit/0336116ed463c2ad125793a5aa4d7290a2155709
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2024-04-22 (Mon, 22 Apr 2024)

  Changed paths:
    M libc/docs/dev/code_style.rst

  Log Message:
  -----------
  [libc][docs] codify Policy on Assembler Sources (#88185)

It would be helpful in future code reviews to document a policy with
regards to
where and when Assembler sources are appropriate. That way when
reviewers point
out infractions, they can point to this written policy, which may help
contributors understand that it's not solely the personal preferences of
individual reviewers but instead rather a previously agreed upon rule by
maintainers.

Link: https://github.com/llvm/llvm-project/pull/87837
Link: https://github.com/llvm/llvm-project/pull/88157
Link:
https://discourse.llvm.org/t/hand-written-in-assembly-in-libc-setjmp-longjmp/73249/12



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list