[all-commits] [llvm/llvm-project] 758d97: [MIPS]: Rework atomic max/min expand for subword (...

YunQiang Su via All-commits all-commits at lists.llvm.org
Mon Apr 22 11:08:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 758d97dce0c669a0ba6927728b40030a76acb144
      https://github.com/llvm/llvm-project/commit/758d97dce0c669a0ba6927728b40030a76acb144
  Author: YunQiang Su <syq at debian.org>
  Date:   2024-04-23 (Tue, 23 Apr 2024)

  Changed paths:
    M llvm/lib/Target/Mips/MipsExpandPseudo.cpp
    M llvm/test/CodeGen/Mips/atomic-min-max.ll

  Log Message:
  -----------
  [MIPS]: Rework atomic max/min expand for subword (#89575)

The current code is so buggy: it can work for few cases. The problems
include:
1. ll/sc works on a whole word, while other parts other than we rmw are
dropped.
  2. The oprands are not well zero-extended for unsigned ops.
3. It doesn't work for big-endian, as the postion of subword differs
with little endian.

And in fact, we can set the return value correct in ll/sc scope, so we
can skip the sinkMBB.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list