[all-commits] [llvm/llvm-project] 090d03: [MLIR][LLVM] Add flag to skip import of DIComposit...

[Christian Ulmann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 090d03d1c7eef4f9790b9300f19176e8f49151dd
      https://github.com/llvm/llvm-project/commit/090d03d1c7eef4f9790b9300f19176e8f49151dd
  Author: Christian Ulmann <christianulmann at gmail.com>
  Date:   2024-04-19 (Fri, 19 Apr 2024)

  Changed paths:
    M mlir/include/mlir/Target/LLVMIR/Import.h
    M mlir/include/mlir/Target/LLVMIR/ModuleImport.h
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/lib/Target/LLVMIR/DebugImporter.cpp
    M mlir/lib/Target/LLVMIR/DebugImporter.h
    M mlir/lib/Target/LLVMIR/ModuleImport.cpp
    A mlir/test/Target/LLVMIR/Import/ignore-composite-type-elements.ll

  Log Message:
  -----------
  [MLIR][LLVM] Add flag to skip import of DICompositeType's elems (#89355)

This commit introduces a flag to allow skipping the potentially
recursive import of DICompositeType elements. This patch is essentially a
bandaid for the still broken recursive debug type import.

Some of our downstream inputs are produced by excessive usage of
template meta programming, and thus contain tens of thousands of types
that all participate in such recursions. Unfortunately, the series of
patches that introduces type support is not easily revertible due to
being around for a while now and Modular depending on it.

We can consider to revert this change once the type importer has show to
be very performant, but for now we are talking second vs hours to import
specific files.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications