[all-commits] [llvm/llvm-project] 949e66: [Coverage][NFC] Avoid visiting non-unique `OpaqueV...

Andrey Ali Khan Bolshakov via All-commits all-commits at lists.llvm.org
Thu Apr 18 17:04:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 949e66baf1c5d97dc60a243d9b66df5216255343
      https://github.com/llvm/llvm-project/commit/949e66baf1c5d97dc60a243d9b66df5216255343
  Author: Andrey Ali Khan Bolshakov <bolsh.andrey at yandex.ru>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M clang/lib/CodeGen/CoverageMappingGen.cpp

  Log Message:
  -----------
  [Coverage][NFC] Avoid visiting non-unique `OpaqueValueExpr` (#88910)

Only unique `OpaqueValueExpr`s should be handled in the mapping builder,
as
[discussed](https://github.com/llvm/llvm-project/pull/85837#discussion_r1542056451)
in #85837. However, `getCond()` returns non-unique `OpaqueValueExpr` for
`BinaryConditionalOperator` (because it is also used as the "true"
branch expression). Use `getCommon()` instead so as to bypass the
`OpaqueValueExpr`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list