[all-commits] [llvm/llvm-project] 6b3893: Check for null oso SymbolFile in SymbolFileDwarfDe...

[jimingham via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6b3893690b37d6e85cabfd144eca9a738e3baf9b
      https://github.com/llvm/llvm-project/commit/6b3893690b37d6e85cabfd144eca9a738e3baf9b
  Author: jimingham <jingham at apple.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp

  Log Message:
  -----------
  Check for null oso SymbolFile in SymbolFileDwarfDebugMap::ResolveSymbolContext (#89324)

The couple other places that use the oso module's SymbolFile, they check
that it's non-null, so this is just an oversight in
ResolveSymbolContext.

I didn't add a test for this (but did add a log message for the error
case) because I can't see how this would actually happen. The .o file
had to have valid enough DWARF that the linker's parser could handle it
or it would not be in the debug map. If you delete the .o file, we just
leave that entry out of the debug map. If you strip it or otherwise mess
with it, we'll notice the changed mod time and refuse to read it...

This was based on a report from the field, and we don't have access to
the project. But if the logging tells me how this happened I can come
back and add a test with that example.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications