[all-commits] [llvm/llvm-project] 68e814: [AMDGPU] Add disassembler diagnostics for invalid...

[Emma Pilkington via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 68e814d9114b6c8910642298714dad6fa79ccad2
      https://github.com/llvm/llvm-project/commit/68e814d9114b6c8910642298714dad6fa79ccad2
  Author: Emma Pilkington <emma.pilkington95 at gmail.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M llvm/docs/AMDGPUUsage.rst
    M llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h
    M llvm/lib/MC/MCDisassembler/MCDisassembler.cpp
    M llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp
    M llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.h
    M llvm/lib/Target/WebAssembly/Disassembler/WebAssemblyDisassembler.cpp
    A llvm/test/MC/Disassembler/AMDGPU/kernel-descriptor-errors.test
    A llvm/test/MC/Disassembler/AMDGPU/kernel-descriptor-rsrc-errors.test
    M llvm/tools/llvm-objdump/llvm-objdump.cpp

  Log Message:
  -----------
   [AMDGPU] Add disassembler diagnostics for invalid kernel descriptors  (#87400)

These mostly are checking for various reserved bits being set. The diagnostics
for gpu-dependent reserved bits have a bit more context since they seem like the
most likely ones to be observed in practice.

This commit also improves the error handling mechanism for
MCDisassembler::onSymbolStart(). Previously it had a comment stream parameter
that was just being ignored by llvm-objdump, now it returns errors using
Expected<T>.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications