[all-commits] [llvm/llvm-project] 6870ac: Fix saving minidump from lldb-dap (#89113)

[jeffreytan81 via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6870ac201f9f50a13313213fea7a14b198d7280a
      https://github.com/llvm/llvm-project/commit/6870ac201f9f50a13313213fea7a14b198d7280a
  Author: jeffreytan81 <jeffreytan at meta.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp
    A lldb/test/API/tools/lldb-dap/save-core/Makefile
    A lldb/test/API/tools/lldb-dap/save-core/TestDAP_save_core.py
    A lldb/test/API/tools/lldb-dap/save-core/main.cpp

  Log Message:
  -----------
  Fix saving minidump from lldb-dap (#89113)

There are users reporting saving minidump from lldb-dap does not work.

Turns out our stack trace request always evaluate a function call which
caused JIT object file like "__lldb_caller_function" to be created which
can fail minidump builder to get its module size.

This patch fixes "getModuleFileSize" for ObjectFileJIT so that module
list can be saved. I decided to create a lldb-dap test so that this
end-to-end functionality can be validated from our tests (instead of
only command line lldb).

The patch also improves several other small things in the workflow:
1. It logs any minidump stream failure so that it is easier to find out
what stream saving fails. In future, we should show process and error to
end users.
2. It handles error from "getModuleFileSize" llvm::Expected<T> otherwise
it will complain the error is not handled.

---------

Co-authored-by: jeffreytan81 <jeffreytan at fb.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications