[all-commits] [llvm/llvm-project] bc5536: [mlir][python] Fix PyOperationBase::walk not catch...

tomnatan30 via All-commits all-commits at lists.llvm.org
Thu Apr 18 07:09:52 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bc5536469d7854a043dbfe4c018e5b5dfc069d4f
      https://github.com/llvm/llvm-project/commit/bc5536469d7854a043dbfe4c018e5b5dfc069d4f
  Author: tomnatan30 <130450079+tomnatan30 at users.noreply.github.com>
  Date:   2024-04-18 (Thu, 18 Apr 2024)

  Changed paths:
    M mlir/lib/Bindings/Python/IRCore.cpp
    M mlir/test/python/ir/operation.py

  Log Message:
  -----------
  [mlir][python] Fix PyOperationBase::walk not catching exception in python callback (#89225)

If the python callback throws an error, the c++ code will throw a
py::error_already_set that needs to be caught and handled in the c++
code .

This change is inspired by the similar solution in
PySymbolTable::walkSymbolTables.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list