[all-commits] [llvm/llvm-project] 028e42: [MIPS] Fix the opcode of max.fmt and mina.fmt (#85...

Cinhi Young via All-commits all-commits at lists.llvm.org
Tue Apr 16 17:08:13 PDT 2024


  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 028e425f86ccff44aa521c2e2ac428dbda2c13d4
      https://github.com/llvm/llvm-project/commit/028e425f86ccff44aa521c2e2ac428dbda2c13d4
  Author: Cinhi Young <cyanoxygen2725 at gmail.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M llvm/lib/Target/Mips/Mips32r6InstrInfo.td
    M llvm/test/MC/Disassembler/Mips/mips32r6/valid-mips32r6-el.txt
    M llvm/test/MC/Disassembler/Mips/mips32r6/valid-mips32r6.txt
    M llvm/test/MC/Disassembler/Mips/mips64r6/valid-mips64r6-el.txt
    M llvm/test/MC/Disassembler/Mips/mips64r6/valid-mips64r6.txt
    M llvm/test/MC/Mips/mips32r6/valid.s
    M llvm/test/MC/Mips/mips64r6/valid.s

  Log Message:
  -----------
  [MIPS] Fix the opcode of max.fmt and mina.fmt (#85609)

- The opcode of the mina.fmt and max.fmt is documented wrong, the
  object code compiled from the same assembly with LLVM behaves
  differently than one compiled with GCC and Binutils.
- Modify the opcodes to match Binutils. The actual opcodes are as
follows:

  {5,3} | bits {2,0} of func
           |    ...   | 100  | 101    | 110   | 111
  -----+-----+-----+-----+-----+-----
   010  |   ...   |  min  | mina | max  | maxa

(cherry picked from commit 8b859c6e4a8e9ab9969582267bbdc04ed6bfa535)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list