[all-commits] [llvm/llvm-project] 647fbc: [SelectionDAG] Prevent combination on inconsistent...

XChy via All-commits all-commits at lists.llvm.org
Tue Apr 16 12:45:33 PDT 2024


  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 647fbc710840d87698d9dbc016a90c3aa634f532
      https://github.com/llvm/llvm-project/commit/647fbc710840d87698d9dbc016a90c3aa634f532
  Author: XChy <xxs_chy at outlook.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
    M llvm/test/CodeGen/X86/addcarry.ll

  Log Message:
  -----------
  [SelectionDAG] Prevent combination on inconsistent type in `combineCarryDiamond` (#84888)

Fixes #84831
When matching carry pattern with `getAsCarry`, it may produce different
type of carryout. This patch checks such case and does early exit.

I'm new to DAG, any suggestion is appreciated.

(cherry picked from commit cb4453dc69d75064c9a82e9a6a9bf0d0ded4b204)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list