[all-commits] [llvm/llvm-project] 9a0a28: [Libomptarget] Rework Record & Replay to be a plug...

Joseph Huber via All-commits all-commits at lists.llvm.org
Tue Apr 16 12:19:34 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9a0a28f8384b2cb534953df33bf124f01f0e0d0e
      https://github.com/llvm/llvm-project/commit/9a0a28f8384b2cb534953df33bf124f01f0e0d0e
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M openmp/libomptarget/plugins-nextgen/common/include/PluginInterface.h
    M openmp/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp

  Log Message:
  -----------
  [Libomptarget] Rework Record & Replay to be a plugin member (#88928)

Summary:
Previously, the R&R support was global state initialized by a global
constructor. This is bad because it prevents us from adequately
constraining the lifetime of the library. Additionally, we want to
minimize the amount of global state floating around.

This patch moves the R&R support into a plugin member like everything
else. This means there will be multiple copies of the R&R implementation
floating around, but this was already the case given the fact that we
currently handle everything with dynamic libraries.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list