[all-commits] [llvm/llvm-project] 8cd8eb: [MLGO] Use double comparison facilities for reg al...

Aiden Grossman via All-commits all-commits at lists.llvm.org
Tue Apr 16 10:25:23 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8cd8ebe153391993a3668d2ac8d2994d9491f3ef
      https://github.com/llvm/llvm-project/commit/8cd8ebe153391993a3668d2ac8d2994d9491f3ef
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M llvm/unittests/CodeGen/RegAllocScoreTest.cpp

  Log Message:
  -----------
  [MLGO] Use double comparison facilities for reg alloc scoring tests (#88862)

This patch switches from using direct equality (ASSERT_EQ) to the
floating point comparison facilities (ASSERT_DOUBLE_EQ) within google
test to avoid weird floating point problems. There is at least one
downstream that maintains a patch for issues cropping up from the direct
equality.


https://gitlab.alpinelinux.org/alpine/aports/-/blob/master/main/llvm17/allocscore.patch



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list