[all-commits] [llvm/llvm-project] 61717c: [Verifier] Reject va_start in non-variadic functio...

[Jon Chesterfield via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61717c1aa1f08eb57839a21fb2d9004739022e0d
      https://github.com/llvm/llvm-project/commit/61717c1aa1f08eb57839a21fb2d9004739022e0d
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2024-04-16 (Tue, 16 Apr 2024)

  Changed paths:
    M llvm/lib/Analysis/Lint.cpp
    M llvm/lib/IR/Verifier.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/vastart.ll
    M llvm/test/Other/lint.ll
    A llvm/test/Verifier/variadic.ll

  Log Message:
  -----------
  [Verifier] Reject va_start in non-variadic function (#88809)

A va_start intrinsic lowers to something derived from the variadic
parameter to the function. If there is no such parameter, it can't lower
meaningfully. Clang sema rejects the same with `error: 'va_start' used
in function with fixed args`.

Moves the existing lint warning into a verifier error. Updates the one
lit test that had a va_start in a non-variadic function.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications