[all-commits] [llvm/llvm-project] c83797: [Codegen][X86] Fix /HOTPATCH with clang-cl and inl...

[Alexandre Ganea via All-commits]

  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: c837970dd7e97a7ea8eac149ff19357d75c59083
      https://github.com/llvm/llvm-project/commit/c837970dd7e97a7ea8eac149ff19357d75c59083
  Author: Alexandre Ganea <37383324+aganea at users.noreply.github.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M llvm/lib/Target/X86/X86MCInstLower.cpp
    M llvm/test/CodeGen/X86/patchable-prologue.ll

  Log Message:
  -----------
  [Codegen][X86] Fix /HOTPATCH with clang-cl and inline asm (#87639)

This fixes an edge case where functions starting with inline assembly
would assert while trying to lower that inline asm instruction.

After this PR, for now we always add a no-op (xchgw in this case) without
considering the size of the next inline asm instruction. We might want
to revisit this in the future.

This fixes Unreal Engine 5.3.2 compilation with clang-cl and /HOTPATCH.

Should close https://github.com/llvm/llvm-project/issues/56234

(cherry picked from commit ec1af63dde58c735fe60d6f2aafdb10fa93f410d)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications