[all-commits] [llvm/llvm-project] 0287a5: [OpenMP] Remove 'minncta' attributes from NVPTX ke...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0287a5cc4e2a5ded1ae2e4079f91052e6a6b8d9b
      https://github.com/llvm/llvm-project/commit/0287a5cc4e2a5ded1ae2e4079f91052e6a6b8d9b
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M clang/test/OpenMP/ompx_attributes_codegen.cpp
    M llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

  Log Message:
  -----------
  [OpenMP] Remove 'minncta' attributes from NVPTX kernels (#88398)

Summary:
Currently we treat this attribute as a minimum number for the amount of
blocks scheduled on the kernel. However, the doucmentation states that
this applies to CTA's mapped onto a *single* SM. Currently we just set
it to the total number of blocks, which will almost always result in a
warning that the value is out of range and will be ignored. We don't
have a good way to automatically know how many CTAs can be put on a
single SM nor if we should do this, so we should probably leave this up
to users manually adding it.


https://docs.nvidia.com/cuda/parallel-thread-execution/index.html#performance-tuning-directives-minnctapersm



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications