[all-commits] [llvm/llvm-project] 43b4e5: Use pushFullExprCleanup for deferred destroy (#88670)

Utkarsh Saxena via All-commits all-commits at lists.llvm.org
Mon Apr 15 12:30:39 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43b4e5b9bff1719a6d3628a3a805cfeb59adaf16
      https://github.com/llvm/llvm-project/commit/43b4e5b9bff1719a6d3628a3a805cfeb59adaf16
  Author: Utkarsh Saxena <usx at google.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M clang/lib/CodeGen/CGDecl.cpp
    M clang/test/CodeGenCXX/control-flow-in-stmt-expr.cpp

  Log Message:
  -----------
  Use pushFullExprCleanup for deferred destroy (#88670)

Instead of directly pushing the `Destroy`, we should use
`pushFullExprCleanup` which handles conditional branches.
This fixes a backend crash due to
89ba7e183e6e2c64370ed1b963e54c06352211db.

Added minimized crash reproducer.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list