[all-commits] [llvm/llvm-project] 33e60f: Fix rsqrt inaccuracies. (#88707)

Johannes Reifferscheid via All-commits all-commits at lists.llvm.org
Mon Apr 15 03:04:58 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 33e60f358cc0c564e771c0234dd8a60f3bddce5d
      https://github.com/llvm/llvm-project/commit/33e60f358cc0c564e771c0234dd8a60f3bddce5d
  Author: Johannes Reifferscheid <jreiffers at google.com>
  Date:   2024-04-15 (Mon, 15 Apr 2024)

  Changed paths:
    M mlir/lib/Conversion/ComplexToStandard/ComplexToStandard.cpp
    M mlir/test/Conversion/ComplexToStandard/convert-to-standard.mlir
    M mlir/test/Integration/Dialect/Complex/CPU/correctness.mlir

  Log Message:
  -----------
  Fix rsqrt inaccuracies. (#88707)

The current lowering has issues with large/subnormal values. This po
XLA's lowering and was verified using XLA's test suite and the
MLIR-based emitters.

This updates https://github.com/llvm/llvm-project/pull/88691 to also
update the correctness test for rsqrt(0). I checked C++ and Python, they
both agree the result should be (inf, nan). Updated the correctness test
to match this.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list