[all-commits] [llvm/llvm-project] 0ba3e9: [mlir][SCF][NFC] `ValueBoundsConstraintSet`: Simpl...

Matthias Springer via All-commits all-commits at lists.llvm.org
Fri Apr 5 23:30:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ba3e96be114dcbe0ac6813a1d0e2940d2a88229
      https://github.com/llvm/llvm-project/commit/0ba3e96be114dcbe0ac6813a1d0e2940d2a88229
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-04-06 (Sat, 06 Apr 2024)

  Changed paths:
    M mlir/lib/Dialect/SCF/IR/ValueBoundsOpInterfaceImpl.cpp

  Log Message:
  -----------
  [mlir][SCF][NFC] `ValueBoundsConstraintSet`: Simplify `scf.for` implementation (#87862)

This commit simplifies the implementation of the
`ValueBoundsOpInterface` for `scf.for` based on the newly added
`ValueBoundsConstraintSet::compare` API and adds additional
documentation.

Previously, the interface implementation created a new constraint set
just to check if the yielded value and iter_arg are equal. This was
inefficient because constraints were added multiple times (to two
different constraint sets) for ops that are inside the loop.

Note: This is a re-upload of #86239.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list