[all-commits] [llvm/llvm-project] 0f52f4: [mlir][ods] Emit "trivial" ODS getter/setters inli...

Jeff Niu via All-commits all-commits at lists.llvm.org
Fri Apr 5 19:02:00 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0f52f4ddd909eb38f2a691ffed8469263fe5f635
      https://github.com/llvm/llvm-project/commit/0f52f4ddd909eb38f2a691ffed8469263fe5f635
  Author: Jeff Niu <jeff at modular.com>
  Date:   2024-04-06 (Sat, 06 Apr 2024)

  Changed paths:
    M mlir/include/mlir/TableGen/Class.h
    M mlir/test/mlir-tblgen/op-attribute.td
    M mlir/test/mlir-tblgen/op-decl-and-defs.td
    M mlir/test/mlir-tblgen/op-operand.td
    M mlir/test/mlir-tblgen/op-properties.td
    M mlir/test/mlir-tblgen/op-result.td
    M mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

  Log Message:
  -----------
  [mlir][ods] Emit "trivial" ODS getter/setters inline (#87741)

Emitting trivial getters that amount to `(*this)->getOperand(1)`
out-of-line or `getProperties().foo` is a pretty significant performance
hit on these basic MLIR APIs for manipulating ops (3-4x). Emit them
inline (without adding additional dependencies to header files).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list