[all-commits] [llvm/llvm-project] 1f01c5: [GlobalISel] Fix the infinite loop issue in `commu...

darkbuck via All-commits all-commits at lists.llvm.org
Wed Apr 3 17:53:24 PDT 2024


  Branch: refs/heads/users/darkbuck/spr/main.globalisel-handle-more-commutable-instructions-in-commute_constant_to_rhs
  Home:   https://github.com/llvm/llvm-project
  Commit: 1f01c580444ea2daef67f95ffc5fde2de5a37cec
      https://github.com/llvm/llvm-project/commit/1f01c580444ea2daef67f95ffc5fde2de5a37cec
  Author: darkbuck <michael.hliao at gmail.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp
    A llvm/test/CodeGen/AArch64/GlobalISel/combine-commute-int-const-lhs.mir

  Log Message:
  -----------
  [GlobalISel] Fix the infinite loop issue in `commute_int_constant_to_rhs`

- When both operands are constant, the matcher runs into an infinite
  loop as the commutation should be applied only when LHS is a constant
  and RHS is not.

Reviewers: arsenm

Reviewed By: arsenm

Pull Request: https://github.com/llvm/llvm-project/pull/87426


  Commit: a4e6fba6d086e141f3b11bde516eb2c568994d44
      https://github.com/llvm/llvm-project/commit/a4e6fba6d086e141f3b11bde516eb2c568994d44
  Author: darkbuck <michael.hliao at gmail.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:

  Log Message:
  -----------
  [𝘀𝗽𝗿] changes introduced through rebase

Created using spr 1.3.4

[skip ci]


Compare: https://github.com/llvm/llvm-project/compare/a820fa2034de...a4e6fba6d086

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list