[all-commits] [llvm/llvm-project] e61d6b: [lldb][SymbolFileDWARFDebugMap] Introduce enum to ...

[Michael Buch via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e61d6b74ddf28df196484f6251271f543ae902ab
      https://github.com/llvm/llvm-project/commit/e61d6b74ddf28df196484f6251271f543ae902ab
  Author: Michael Buch <michaelbuch12 at gmail.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M lldb/include/lldb/lldb-private-enumerations.h
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h

  Log Message:
  -----------
  [lldb][SymbolFileDWARFDebugMap] Introduce enum to indicate whether to continue iteration of object files (#87344)

This patch introduces a new `IterationMarker` enum (happy to take
alternative name suggestions), which callbacks, like the one in
`SymbolFileDWARFDebugMap::ForEachSymbolFile`, can return in order to
indicate whether the caller should continue iterating or bail.

For now this patch just changes the `ForEachSymbolFile` callback to use
this new enum. In the future we could change the various
`DWARFIndex::GetXXX` callbacks to do the same.

This makes the callbacks easier to read and hopefully reduces the chance
of bugs like https://github.com/llvm/llvm-project/pull/87177.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications