[all-commits] [llvm/llvm-project] 6335de: [libc] Disable '_exit' on the GPU build

Tue Apr 2 15:53:54 PDT 2024

  Branch: refs/heads/users/ilovepi/spr/clang-tidy-restructure-json-profile-structure-to-be-parsable
  Home:   https://github.com/llvm/llvm-project
  Commit: 6335de4a23e4b71020861b872f51bafb79fbe419
      https://github.com/llvm/llvm-project/commit/6335de4a23e4b71020861b872f51bafb79fbe419
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M libc/config/gpu/entrypoints.txt
    M libc/config/gpu/headers.txt

  Log Message:
  -----------
  [libc] Disable '_exit' on the GPU build

Summary:
There are other dependencies to enable `unistd.h` on the GPU which
prevented the header from being generated. This is a POSIX extension and
isn't part of the core `libc`, so we can just disable this for now to
get the bots gree.

  Commit: 7f2a41b643af1348631dee27dc1321046370a758
      https://github.com/llvm/llvm-project/commit/7f2a41b643af1348631dee27dc1321046370a758
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M llvm/lib/CodeGen/MachineScheduler.cpp

  Log Message:
  -----------
  MachineScheduler: Simplify usage of TargetInstrInfo

  Commit: 6b2a4668b99ef47f567709bcf6f57bc60c35eea9
      https://github.com/llvm/llvm-project/commit/6b2a4668b99ef47f567709bcf6f57bc60c35eea9
  Author: Aaron Ballman <aaron at aaronballman.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    A clang/test/C/C11/n1482.c
    M clang/www/c_status.html

  Log Message:
  -----------
  [C11] Claim conformance to WG14 N1482

This paper added a pile of macros for atomic initialization which we
started supporting in Clang 4.0.

  Commit: 817c6915aeadbed100efee9e70eb42d9368d5ee6
      https://github.com/llvm/llvm-project/commit/817c6915aeadbed100efee9e70eb42d9368d5ee6
  Author: Tom Stellard <tstellar at redhat.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M .github/workflows/email-check.yaml
    M .github/workflows/issue-write.yml

  Log Message:
  -----------
  [workflows] Use issue-write workflow for warning about private emails (#87399)

This allows us to use the less privileged pull_request event for the
validate_email job, since this workflow no longer writes a comment
directly.

  Commit: d8db13edd60b195e6692deb04d63e633319e486a
      https://github.com/llvm/llvm-project/commit/d8db13edd60b195e6692deb04d63e633319e486a
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td

  Log Message:
  -----------
  [RISCV][NFC] Delete some unused pseudo multiclasses (#87401)

We only use the `RM` equivalents now.

  Commit: 6261c53c6f9c82bfca5df2ed5917876d748ed079
      https://github.com/llvm/llvm-project/commit/6261c53c6f9c82bfca5df2ed5917876d748ed079
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
    M llvm/lib/Transforms/Vectorize/VPlan.h
    A llvm/test/Transforms/LoopVectorize/pr87378-vpinstruction-or-drop-poison-generating-flags.ll

  Log Message:
  -----------
  [VPlan] Make sure OR VPInstructions are treated as disjoint ops.

Make sure that VPInstructions with OR opcodes are properly registered as
disjoint ops.

Fixes https://github.com/llvm/llvm-project/issues/87378.

  Commit: c3e3d59fab8ae8161810c861d78c7b5fcabb1a2e
      https://github.com/llvm/llvm-project/commit/c3e3d59fab8ae8161810c861d78c7b5fcabb1a2e
  Author: Han-Chung Wang <hanhan0912 at gmail.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
    M mlir/test/Dialect/Tensor/canonicalize.mlir

  Log Message:
  -----------
  [mlir][tensor] Fix tensor::PackOp fold() handling of padding value (#87296)

We can't just check if it is a splat constant or not. We should also
check if the value match.

  Commit: f119a4ffb885ed588c46de1d51f4185572142ca2
      https://github.com/llvm/llvm-project/commit/f119a4ffb885ed588c46de1d51f4185572142ca2
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M clang/test/CodeGenHLSL/builtins/wave_get_lane_index_subcall.hlsl

  Log Message:
  -----------
  [HLSL] Fix broken spir-v test

This fixes a test broken in 3d469c0e7c3072f0dad0f5e9bd0c74dffaf83cd3.
fast-forwarded.
../clang/test/CodeGenHLSL/builtins/wave_get_lane_index_subcall.hlsl

  Commit: 4ea24946e356be31446fc30ca3d11cc5783ba2a6
      https://github.com/llvm/llvm-project/commit/4ea24946e356be31446fc30ca3d11cc5783ba2a6
  Author: Jonathan Peyton <jonathan.l.peyton at intel.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M openmp/runtime/src/kmp_tasking.cpp
    A openmp/runtime/test/tasking/issue-87307.c

  Log Message:
  -----------
  [OpenMP] Fix nested parallel with tasking (#87309)

When a nested parallel region ends, the runtime calls __kmp_join_call().
During this call, the primary thread of the nested parallel region will
reset its tid (retval of omp_get_thread_num()) to what it was in the
outer parallel region. A data race occurs with the current code when
another worker thread from the nested inner parallel region tries to
steal tasks from the primary thread's task deque. The worker thread
reads the tid value directly from the primary thread's data structure
and may read the wrong value.

This change just uses the calculated victim_tid from execute_tasks()
directly in the steal_task() routine rather than reading tid from the
data structure.

Fixes: #87307

  Commit: 89271b46761749503dffe94c60b9cbe0bda80284
      https://github.com/llvm/llvm-project/commit/89271b46761749503dffe94c60b9cbe0bda80284
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    A llvm/test/Transforms/LoopVectorize/RISCV/pr87378-vpinstruction-or-drop-poison-generating-flags.ll
    R llvm/test/Transforms/LoopVectorize/pr87378-vpinstruction-or-drop-poison-generating-flags.ll

  Log Message:
  -----------
  [LV] Add test depending on target to RISCV subdirectory.

  Commit: 7327014b49ba0e4c8227edaed569d21d3cc1ec74
      https://github.com/llvm/llvm-project/commit/7327014b49ba0e4c8227edaed569d21d3cc1ec74
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M libc/config/gpu/entrypoints.txt
    M libc/include/llvm-libc-types/rpc_opcodes_t.h
    M libc/spec/gpu_ext.td
    M libc/src/__support/arg_list.h
    M libc/src/gpu/CMakeLists.txt
    A libc/src/gpu/rpc_fprintf.cpp
    A libc/src/gpu/rpc_fprintf.h
    M libc/test/integration/src/stdio/CMakeLists.txt
    A libc/test/integration/src/stdio/gpu/CMakeLists.txt
    A libc/test/integration/src/stdio/gpu/printf.cpp
    M libc/utils/gpu/server/CMakeLists.txt
    M libc/utils/gpu/server/rpc_server.cpp

  Log Message:
  -----------
  [libc] Implement temporary `printf` on the GPU (#85331)

Summary:
This patch adds a temporary implementation that uses a struct-based
interface in lieu of varargs support. Once varargs support exists we
will move this implementation to the "real" printf implementation.

Conceptually, this patch has the client copy over its format string and
arguments to the server. The server will then scan the format string
searching for any specifiers that are actually a string. If it is a
string then we will send the pointer back to the server to tell it to
copy it back. This copied value will then replace the pointer when the
final formatting is done.

This will require a built-in extension to the varargs support to get
access to the underlying struct. The varargs used on the GPU will simply
be a struct wrapped in a varargs ABI.

  Commit: 5029949952f4dc745dcb7799c7449a02fe8309c3
      https://github.com/llvm/llvm-project/commit/5029949952f4dc745dcb7799c7449a02fe8309c3
  Author: Daniil Kovalev <dkovalev at accesssoftek.com>
  Date:   2024-04-03 (Wed, 03 Apr 2024)

  Changed paths:
    M llvm/include/llvm/BinaryFormat/ELF.h
    M llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-feature-pauth.s
    M llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-note-gnu-property.s
    M llvm/tools/llvm-readobj/ELFDumper.cpp

  Log Message:
  -----------
  [PAC][llvm-readobj][AArch64][ELF] Support `GNU_PROPERTY_AARCH64_FEATURE_PAUTH` (#85231)

This adds support for `GNU_PROPERTY_AARCH64_FEATURE_PAUTH` feature (as
defined in https://github.com/ARM-software/abi-aa/pull/240) handling in
llvm-readobj and llvm-readelf. The following constants for supported
platforms are also introduced:

- `AARCH64_PAUTH_PLATFORM_INVALID = 0x0`
- `AARCH64_PAUTH_PLATFORM_BAREMETAL = 0x1`
- `AARCH64_PAUTH_PLATFORM_LLVM_LINUX = 0x10000002`

For the llvm_linux platform, output of the tools contains descriptions
of PAuth features which are enabled/disabled depending on the version
value. Version value bits correspond to the following `LangOptions`
defined in #85232:

- bit 0: `PointerAuthIntrinsics`;
- bit 1: `PointerAuthCalls`;
- bit 2: `PointerAuthReturns`;
- bit 3: `PointerAuthAuthTraps`;
- bit 4: `PointerAuthVTPtrAddressDiscrimination`;
- bit 5: `PointerAuthVTPtrTypeDiscrimination`;
- bit 6: `PointerAuthInitFini`.

Support for `.note.AARCH64-PAUTH-ABI-tag` is dropped since it's deleted
from the spec in ARM-software/abi-aa#250.

  Commit: 2cf8118e3aa60f406ec41e88bdd4304f39744e89
      https://github.com/llvm/llvm-project/commit/2cf8118e3aa60f406ec41e88bdd4304f39744e89
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M openmp/libomptarget/DeviceRTL/CMakeLists.txt
    M openmp/libomptarget/DeviceRTL/src/LibC.cpp
    A openmp/libomptarget/test/libc/printf.c

  Log Message:
  -----------
  [Libomptarget] Add RPC-based `printf` implementation for OpenMP (#85638)

Summary:
This patch adds an implementation of `printf` that's provided by the GPU
C library runtime. This `pritnf` currently implemented using the same
wrapper handling that OpenMP sets up. This will be removed once we have
proper varargs support.

This `printf` differs from the one CUDA offers in that it is synchronous
and uses a finite size. Additionally we support pretty much every format
specifier except the `%n` option.

Depends on https://github.com/llvm/llvm-project/pull/85331

  Commit: a7f4576ff4e296ff42b16d9d91aadf82b5ea325c
      https://github.com/llvm/llvm-project/commit/a7f4576ff4e296ff42b16d9d91aadf82b5ea325c
  Author: Owen Pan <owenpiano at gmail.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M clang/lib/Format/TokenAnnotator.cpp
    M clang/unittests/Format/TokenAnnotatorTest.cpp

  Log Message:
  -----------
  [clang-format] Fix a regression in annotating TrailingReturnArrow (#86624)

Fixes #86559.

  Commit: e381586f259568bf244fcd857ce91fc5cb38b959
      https://github.com/llvm/llvm-project/commit/e381586f259568bf244fcd857ce91fc5cb38b959
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M libc/src/__support/macros/config.h

  Log Message:
  -----------
  [libc] Work around lack of '__has_builtin' for GPU server (#87417)

Summary:
The RPC server build for the GPU support needs to be build from the
"projects" phase of the LLVM build. That means it is built with the same
compile that LLVM supports, which currently is GCC 7.4 in most cases.
A previous patch removed the `LIBC_HAS_BUILTIN` indirection we used,
which regressed the case where we used the `libc` source externally. The
files that we need to use here are `converter.cpp` and `writer.cpp`
which currently are compatible with C++17, so there aren't issues with
the code itself. However, older GCC does not have this builtin which
makes the checks fail.

This patch just adds in a simple wrapper that allows it to correctly
ignore everything if using a compiler that doesn't support it.

  Commit: 68217a52fb9fec8a88623f97a90899b8d27eefb3
      https://github.com/llvm/llvm-project/commit/68217a52fb9fec8a88623f97a90899b8d27eefb3
  Author: Haowei <haowei at google.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M clang/cmake/caches/Fuchsia.cmake

  Log Message:
  -----------
  [Fuchsia] Add SWIG flags to Fuchsia Clang stage2 build (#87421)

This patch adds SWIG cmake flags to the stage2 build in Fuchsia
Clang configuration.

  Commit: b4adb42151bbfa80be4cf6d076cbe5edf680693e
      https://github.com/llvm/llvm-project/commit/b4adb42151bbfa80be4cf6d076cbe5edf680693e
  Author: Jon Chesterfield <jonathanchesterfield at gmail.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M clang/lib/Tooling/CMakeLists.txt

  Log Message:
  -----------
  Use setup_host_tool for clang-ast-dump, fixes 76707

  Commit: 633bc3bfda71c55bc38d5a3bfdb426bab61ff101
      https://github.com/llvm/llvm-project/commit/633bc3bfda71c55bc38d5a3bfdb426bab61ff101
  Author: Vitaly Buka <vitalybuka at google.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M clang/lib/CodeGen/BackendUtil.cpp

  Log Message:
  -----------
  [CodeGen][NFC] Make an opt<> static

  Commit: 06ab9e4f4eb3df4a9491d9492bf4a4564b2ced56
      https://github.com/llvm/llvm-project/commit/06ab9e4f4eb3df4a9491d9492bf4a4564b2ced56
  Author: Paul Kirth <paulkirth at google.com>
  Date:   2024-04-02 (Tue, 02 Apr 2024)

  Changed paths:
    M .github/workflows/email-check.yaml
    M .github/workflows/issue-write.yml
    M clang/cmake/caches/Fuchsia.cmake
    M clang/lib/CodeGen/BackendUtil.cpp
    M clang/lib/Format/TokenAnnotator.cpp
    M clang/lib/Tooling/CMakeLists.txt
    M clang/test/Analysis/plist-stats-output.c
    A clang/test/C/C11/n1482.c
    M clang/test/CodeGenHLSL/builtins/wave_get_lane_index_subcall.hlsl
    M clang/unittests/Format/TokenAnnotatorTest.cpp
    M clang/www/c_status.html
    M libc/config/gpu/entrypoints.txt
    M libc/config/gpu/headers.txt
    M libc/include/llvm-libc-types/rpc_opcodes_t.h
    M libc/spec/gpu_ext.td
    M libc/src/__support/arg_list.h
    M libc/src/__support/macros/config.h
    M libc/src/gpu/CMakeLists.txt
    A libc/src/gpu/rpc_fprintf.cpp
    A libc/src/gpu/rpc_fprintf.h
    M libc/test/integration/src/stdio/CMakeLists.txt
    A libc/test/integration/src/stdio/gpu/CMakeLists.txt
    A libc/test/integration/src/stdio/gpu/printf.cpp
    M libc/utils/gpu/server/CMakeLists.txt
    M libc/utils/gpu/server/rpc_server.cpp
    M llvm/include/llvm/BinaryFormat/ELF.h
    M llvm/lib/CodeGen/MachineScheduler.cpp
    M llvm/lib/Support/Timer.cpp
    M llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
    M llvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
    M llvm/lib/Transforms/Vectorize/VPlan.h
    A llvm/test/Transforms/LoopVectorize/RISCV/pr87378-vpinstruction-or-drop-poison-generating-flags.ll
    M llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-feature-pauth.s
    M llvm/test/tools/llvm-readobj/ELF/AArch64/aarch64-note-gnu-property.s
    M llvm/tools/llvm-readobj/ELFDumper.cpp
    M mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
    M mlir/test/Dialect/Tensor/canonicalize.mlir
    M openmp/libomptarget/DeviceRTL/CMakeLists.txt
    M openmp/libomptarget/DeviceRTL/src/LibC.cpp
    A openmp/libomptarget/test/libc/printf.c
    M openmp/runtime/src/kmp_tasking.cpp
    A openmp/runtime/test/tasking/issue-87307.c

  Log Message:
  -----------
  Triage plist test

Created using spr 1.3.4

Compare: https://github.com/llvm/llvm-project/compare/156c6b7473fa...06ab9e4f4eb3

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications