[all-commits] [llvm/llvm-project] 688d71: [libclc] Track dependencies through dependency fil...

Fraser Cormack via All-commits all-commits at lists.llvm.org
Thu Mar 28 13:29:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 688d71ea8817ace88955671c1af7c80fbfba2c7f
      https://github.com/llvm/llvm-project/commit/688d71ea8817ace88955671c1af7c80fbfba2c7f
  Author: Fraser Cormack <fraser at codeplay.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M libclc/cmake/CMakeCLCInformation.cmake

  Log Message:
  -----------
  [libclc] Track dependencies through dependency files (#86965)

This commit fixes the problem of missing build dependencies between
libclc source files and their various includes (namely headers and .inc
files).

We would like to do this with compiler-generated dependency files
because then the dependencies are accurate and there are no false
positives, leading to unnecessary rebuilds. This is how regular C/C++
dependencies are usually tracked by CMake.

Note that this variable is an internal API so is not guaranteed to work,
but then again *all* of CMake's support for new languages (which we use
for CLC/LL languages) is an internal API. On balance this change is
probably worth it due to how minimally invasive it is. It should work
with all supported compilers and CMake generators.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list