[all-commits] [llvm/llvm-project] 6f10dc: [HLSL] Add validation for the -enable-16bit-types ...

[Joshua Batista via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6f10dccbab4630604f8a6073ac4b9fb61bf8fc9e
      https://github.com/llvm/llvm-project/commit/6f10dccbab4630604f8a6073ac4b9fb61bf8fc9e
  Author: Joshua Batista <jbatista at microsoft.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticDriverKinds.td
    M clang/lib/Driver/ToolChains/HLSL.cpp
    M clang/lib/Frontend/CompilerInvocation.cpp
    M clang/test/CodeGenHLSL/builtins/RWBuffer-elementtype.hlsl
    A clang/test/Options/enable_16bit_types_validation.hlsl
    A clang/test/Options/enable_16bit_types_validation_spirv.hlsl

  Log Message:
  -----------
  [HLSL] Add validation for the -enable-16bit-types option (#85340)

Previously, the clang compiler with the dxc driver would accept the
-enable-16bit-types flag without checking to see if the required
conditions are met for proper processing of the flag.
Specifically, -enable-16bit-types requires a shader model of at least
6.2 and an HLSL version of at least 2021.
This PR adds a validation check for these other options having the
required values, and emits an error if these constraints are not met.
Fixes #57876

---------

Co-authored-by: Damyan Pepper <damyanp at microsoft.com>
Co-authored-by: Chris B <cbieneman at microsoft.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications