[all-commits] [llvm/llvm-project] 1607e8: [InlineCost] Disable cost-benefit when sample base...

[Xiangyang (Mark) Guo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1607e8212caa7c050d89b5b143531edb815ec7f3
      https://github.com/llvm/llvm-project/commit/1607e8212caa7c050d89b5b143531edb815ec7f3
  Author: Xiangyang (Mark) Guo <helloguo at fb.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M llvm/lib/Analysis/InlineCost.cpp
    M llvm/test/Transforms/SampleProfile/remarks-hotness.ll

  Log Message:
  -----------
  [InlineCost] Disable cost-benefit when sample based PGO is used (#86626)

#66457 makes InlineCost to use cost-benefit by default, which causes
0.4-0.5% performance regression on multiple internal workloads. See
discussions https://github.com/llvm/llvm-project/pull/66457. This pull
request reverts it.

Co-authored-by: helloguo <helloguo at meta.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications