[all-commits] [llvm/llvm-project] 4ddd4e: [AIX][TOC] -mtocdata/-mno-tocdata fix non determin...

[Zaara Syeda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4ddd4ed7fe15a356dace649e18492dd01071f475
      https://github.com/llvm/llvm-project/commit/4ddd4ed7fe15a356dace649e18492dd01071f475
  Author: Zaara Syeda <syzaara at ca.ibm.com>
  Date:   2024-03-28 (Thu, 28 Mar 2024)

  Changed paths:
    M clang/lib/Driver/ToolChains/AIX.cpp
    M clang/test/Driver/toc-conf.c

  Log Message:
  -----------
  [AIX][TOC] -mtocdata/-mno-tocdata fix non deterministic iteration order (#86840)

Failure with testcase toc-conf.c observed when building with
LLVM_REVERSE_ITERATION=ON.
Changing from using llvm::StringSet to std::set<llvm:StringRef> to
ensure iteration order is deterministic. Note: the functionality of the
feature does not require a specific iteration order, however, this will
allow testing to be consistent.
>From llvm docs:
The advantages of std::set are that its iterators are stable (deleting
or inserting an element from the set does not affect iterators or
pointers to other elements) and that iteration over the set is
guaranteed to be in sorted order.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications