[all-commits] [llvm/llvm-project] 767b61: [lld/ELF][X86] Respect outSecOff when checking if ...

Arthur Eubanks via All-commits all-commits at lists.llvm.org
Wed Mar 27 16:17:48 PDT 2024


  Branch: refs/heads/release/18.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 767b61c159b32d1facf7680c8f1b0bfefb08ff71
      https://github.com/llvm/llvm-project/commit/767b61c159b32d1facf7680c8f1b0bfefb08ff71
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M lld/ELF/Arch/X86_64.cpp
    M lld/test/ELF/x86-64-gotpc-relax-too-far.s

  Log Message:
  -----------
  [lld/ELF][X86] Respect outSecOff when checking if GOTPCREL can be relaxed (#86334)

The existing implementation didn't handle when the input text section
was some offset from the output section.

This resulted in an assert in relaxGot() with an lld built with asserts
for some large binaries, or even worse, a silently broken binary with an
lld without asserts.

(cherry picked from commit 48048051323d5dd74057dc5f32df8c3c323afcd5)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list