[all-commits] [llvm/llvm-project] f1dff8: [mlir][bazel] Expose GPUCommonPass.h only by a sin...

Christian Sigg via All-commits all-commits at lists.llvm.org
Tue Mar 26 22:08:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1dff836593d4601e3ad78117df1d980d284bb9c
      https://github.com/llvm/llvm-project/commit/f1dff836593d4601e3ad78117df1d980d284bb9c
  Author: Christian Sigg <chsigg at users.noreply.github.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  [mlir][bazel] Expose GPUCommonPass.h only by a single target. (#86730)

Move `GPUOpsLowering.cpp` from `//mlir:GPUCommonTransforms` to
`//mlir:GPUToGPURuntimeTransforms` to match the CMake setup.

Ideally, header files should be used by only one target, but this is
hard because CMake is less strict with headers (no layering check). But
even with bazel, headers should only be exported once in the `hdrs`
attribute. Other targets may use them in the `srcs` attribute to avoid
circular dependencies.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list