[all-commits] [llvm/llvm-project] fa1b80: [mlir] fix crash in transform.print verification (...

ftynse via All-commits all-commits at lists.llvm.org
Tue Mar 26 18:58:28 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fa1b807befdc7b31b1c0e0ab625170924f7b4951
      https://github.com/llvm/llvm-project/commit/fa1b807befdc7b31b1c0e0ab625170924f7b4951
  Author: Oleksandr "Alex" Zinenko <zinenko at google.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M mlir/lib/Dialect/Transform/IR/TransformOps.cpp
    M mlir/test/Dialect/Transform/ops-invalid.mlir

  Log Message:
  -----------
  [mlir] fix crash in transform.print verification (#86679)

Transform op trait verification calls `getEffects`, and since trait
verification runs before op verification, this call cannot assume the op
to be valid. However, the operand getters now return a `TypedValue` that
unconditionally casts the value to the expected type, leading to an
assertion failure. Use the untyped mechanism instead.

Fixes #84701.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list