[all-commits] [llvm/llvm-project] 09155a: [LegalizeDAG] Remove unneeded temporary SDValues f...

Fangrui Song via All-commits all-commits at lists.llvm.org
Tue Mar 26 18:57:19 PDT 2024


  Branch: refs/heads/users/MaskRay/spr/elf-pack-dyn-relocsandroid-place-irelative-in-reladyn
  Home:   https://github.com/llvm/llvm-project
  Commit: 09155ac290b0906ac8011c87ee43d7c7a2710387
      https://github.com/llvm/llvm-project/commit/09155ac290b0906ac8011c87ee43d7c7a2710387
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp

  Log Message:
  -----------
  [LegalizeDAG] Remove unneeded temporary SDValues from PerformInsertVectorEltInMemory. NFC

There were 3 temporaries that just renamed the 3 well name arguments to the
function to Tmp1-3. Looks like this was done when the code was extracted from
elsewhere into a separate function 15 years ago.


  Commit: b1a633bc014a845a58f0f3c4e442219051646c19
      https://github.com/llvm/llvm-project/commit/b1a633bc014a845a58f0f3c4e442219051646c19
  Author: Alex MacLean <amaclean at nvidia.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp

  Log Message:
  -----------
  [NFC][NVPTX] remove truncating c-style cast (#85889)

While a stack size large enough to cause this truncation to be a problem
would certainly cause other issues and not produce a valid program
anyway, this cast is triggering our Coverity static analysis. Removing
it seems cleaner.


  Commit: 7db40463229bb1c9fb15b2107d878fe70d1eda65
      https://github.com/llvm/llvm-project/commit/7db40463229bb1c9fb15b2107d878fe70d1eda65
  Author: Vadim Paretsky <vadim.paretsky at intel.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M openmp/runtime/src/kmp_collapse.cpp
    A openmp/runtime/test/worksharing/for/collapse_test.inc
    A openmp/runtime/test/worksharing/for/omp_collapse_many_GELTGT_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_GTGEGT_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_LTLEGE_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_one_int.c

  Log Message:
  -----------
  [OpenMP] add loop collapse tests (#86243)

This PR adds loop collapse tests ported from MSVC.

---------

Co-authored-by: Vadim Paretsky <b-vadipa at microsoft.com>


  Commit: c43932ebdc407ed9633f7468dcb061b635e99a8d
      https://github.com/llvm/llvm-project/commit/c43932ebdc407ed9633f7468dcb061b635e99a8d
  Author: SevenIsSeven <150881358+SevenIsSeven at users.noreply.github.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M llvm/include/llvm/IR/BasicBlock.h

  Log Message:
  -----------
  fix build error in MSVC build (#86622)

This commit(https://github.com/llvm/llvm-project/pull/84738) introduced
following compile warning then treated-as-error in MSVC build.

>>>"'^': unsafe mix of type 'unsigned int' and type 'bool' in operation"

---------

Co-authored-by: Seven <Seven.Li at amd.com>


  Commit: 3324f4d4f4bd82bc9fd43062d21a450671a3531b
      https://github.com/llvm/llvm-project/commit/3324f4d4f4bd82bc9fd43062d21a450671a3531b
  Author: Aart Bik <ajcbik at google.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
    A mlir/test/Dialect/SparseTensor/no_fold_into_consumer.mlir

  Log Message:
  -----------
  [mlir][sparse] avoid incompatible linalg fuse-into-consumer (#86752)

This fixes an "infinite" loop bug, where the incoming IR was repeatedly
rewritten while adding identical cast operations. The test for
compatible types should include the notion of an encoding. If it
differs, then a
naive fusion into the consumer is invalid.


  Commit: 54a9f0e441c7cc3c954d24cfde00cb933306a9e9
      https://github.com/llvm/llvm-project/commit/54a9f0e441c7cc3c954d24cfde00cb933306a9e9
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
    M llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
    M llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
    M llvm/lib/Target/RISCV/RISCVInstrGISel.td
    A llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/rvv/vscale32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/rvv/vscale64.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rvv/legalize-vscale-rv32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rvv/legalize-vscale-rv64.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/rvv/vscale-rv32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/rvv/vscale-rv64.mir

  Log Message:
  -----------
  [RISCV][GISEL] Legalize, regbankselect, and instruction-select G_VSCALE (#85967)

G_VSCALE should be lowered using VLENB. If the type is not sXLen it
should be lowered using a G_VSCALE on the narrow type and a G_MUL.
regbank select and instruction select are straightforward so we really
only need to add tests to show it works.


  Commit: 373d8755140df0c760e9c292c5f88479cdda6f4c
      https://github.com/llvm/llvm-project/commit/373d8755140df0c760e9c292c5f88479cdda6f4c
  Author: Pavel Kosov <kpdev42 at gmail.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/CodeGen/CGExpr.cpp
    A clang/test/CodeGen/cfi-check-attrs.c
    M clang/test/CodeGen/cfi-check-fail.c

  Log Message:
  -----------
  [cfi][CodeGen] Call SetLLVMFunctionAttributes{,ForDefinition} on __cf… (#78253)

…i_check

This causes __cfi_check, just as __cfi_check_fail, to get the proper
target-specific attributes, in particular uwtable for unwind table
generation. Previously, nounwind attribute could be inferred for
__cfi_check, which caused it to lose its unwind table even with
-funwind-table option.

~~

Huawei RRI, OS Lab

Co-authored-by: Nikolai Kholiavin <kholiavin.nikolai at huawei-partners.com>


  Commit: d345599c2851c7ef25d2350244cbfe7cfef36386
      https://github.com/llvm/llvm-project/commit/d345599c2851c7ef25d2350244cbfe7cfef36386
  Author: Michael Maitland <michaeltmaitland at gmail.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
    M llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
    M llvm/lib/CodeGen/LowLevelTypeUtils.cpp
    M llvm/lib/CodeGen/MachineVerifier.cpp
    M llvm/lib/CodeGen/RegisterBankInfo.cpp

  Log Message:
  -----------
  [GISEL][NFC] Use getElementCount instead of getNumElements in more places

These cases in particular are  done as a precommit to support
legalization, regbank selection, and instruction selection for extends,
splat vectors, and integer compares in #85938.


  Commit: d023995ae2cc6ab968ec305ea7b6f11b6ac2e78f
      https://github.com/llvm/llvm-project/commit/d023995ae2cc6ab968ec305ea7b6f11b6ac2e78f
  Author: Changpeng Fang <changpeng.fang at amd.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M clang/lib/CodeGen/CGBuiltin.cpp

  Log Message:
  -----------
  AMDGPU: Simplify EmitAMDGPUBuiltinExpr for load transposes, NFC (#86707)

We should not manually get the types of the loading data.
Instead, we can get the types from the intrinsics directly.


  Commit: 4720e3831b814fdd2e8441ee0ac05b6934fdf533
      https://github.com/llvm/llvm-project/commit/4720e3831b814fdd2e8441ee0ac05b6934fdf533
  Author: Enna1 <xumingjie.enna1 at bytedance.com>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary64.h

  Log Message:
  -----------
  [NFC][Sanitizer] Refine the restriction on SizeClassAllocator64::kRegionSize (#86270)

This patch replaces the `SANITIZER_WORDSIZE / 2` with
`sizeof(CompactPtrT) * 8`, replaces hardcoded `4` with
`kCompactPtrScale` in assertion.


  Commit: 10b07f2324aa990664c4141ffab534603af35c7a
      https://github.com/llvm/llvm-project/commit/10b07f2324aa990664c4141ffab534603af35c7a
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-03-27 (Wed, 27 Mar 2024)

  Changed paths:
    M mlir/include/mlir/Interfaces/ValueBoundsOpInterface.h
    M mlir/lib/Interfaces/ValueBoundsOpInterface.cpp

  Log Message:
  -----------
  [mlir][Interfaces] `ValueBoundsConstraintSet`: Add `dump` helper function (#86634)

This commit adds a helper function that dumps the constraint set and the
mapping of columns to values/dims. For debugging only.

Example output:
```
==========
Columns:
(column	dim	value)
 0	1	linalg.fill (result 0)
 1	1	tensor.extract_slice (result 0)
 2	n/a	affine.min (result 0)
 3	n/a	scf.for (bbarg 0)
 4	n/a	func.func (bbarg 2)

Constraint set:
Domain: 0, Range: 1, Symbols: 4, Locals: 0
6 constraints
(None	None	None	None	None	const)
 1	-1	0	0	0	0	= 0
 0	1	-1	0	0	0	= 0
 0	0	-1	-1	1	0	>= 0
 0	0	-1	0	0	4	>= 0
 0	0	0	1	0	0	>= 0
 0	0	0	-1	1	-1	>= 0
==========
```


  Commit: 0aa983b4c22634206d79563ba0bc6b248089e347
      https://github.com/llvm/llvm-project/commit/0aa983b4c22634206d79563ba0bc6b248089e347
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M clang/docs/ReleaseNotes.rst
    M clang/lib/CodeGen/CGBuiltin.cpp
    M clang/lib/CodeGen/CGExpr.cpp
    A clang/test/CodeGen/cfi-check-attrs.c
    M clang/test/CodeGen/cfi-check-fail.c
    M compiler-rt/lib/sanitizer_common/sanitizer_allocator_primary64.h
    M lld/ELF/Relocations.cpp
    M lld/test/ELF/pack-dyn-relocs-ifunc.s
    M llvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
    M llvm/include/llvm/IR/BasicBlock.h
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/lib/CodeGen/GlobalISel/LegalizerInfo.cpp
    M llvm/lib/CodeGen/GlobalISel/MachineIRBuilder.cpp
    M llvm/lib/CodeGen/LowLevelTypeUtils.cpp
    M llvm/lib/CodeGen/MachineVerifier.cpp
    M llvm/lib/CodeGen/RegisterBankInfo.cpp
    M llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
    M llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
    M llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp
    M llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.h
    M llvm/lib/Target/RISCV/RISCVInstrGISel.td
    A llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/rvv/vscale32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/instruction-select/rvv/vscale64.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rvv/legalize-vscale-rv32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/legalizer/rvv/legalize-vscale-rv64.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/rvv/vscale-rv32.mir
    A llvm/test/CodeGen/RISCV/GlobalISel/regbankselect/rvv/vscale-rv64.mir
    M mlir/include/mlir/Interfaces/ValueBoundsOpInterface.h
    M mlir/lib/Dialect/Tensor/IR/TensorOps.cpp
    M mlir/lib/Interfaces/ValueBoundsOpInterface.cpp
    A mlir/test/Dialect/SparseTensor/no_fold_into_consumer.mlir
    M openmp/runtime/src/kmp_collapse.cpp
    A openmp/runtime/test/worksharing/for/collapse_test.inc
    A openmp/runtime/test/worksharing/for/omp_collapse_many_GELTGT_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_GTGEGT_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_LTLEGE_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_many_int.c
    A openmp/runtime/test/worksharing/for/omp_collapse_one_int.c

  Log Message:
  -----------
  fix comment

Created using spr 1.3.5-bogner


Compare: https://github.com/llvm/llvm-project/compare/51e41399fc0c...0aa983b4c226

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list