[all-commits] [llvm/llvm-project] 4dc322: [Libomptarget] Replace global `PluginTy::get` inte...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4dc322524871df02578a05b260dacf28ff130c02
      https://github.com/llvm/llvm-project/commit/4dc322524871df02578a05b260dacf28ff130c02
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-03-26 (Tue, 26 Mar 2024)

  Changed paths:
    M openmp/libomptarget/plugins-nextgen/amdgpu/src/rtl.cpp
    M openmp/libomptarget/plugins-nextgen/common/include/PluginInterface.h
    M openmp/libomptarget/plugins-nextgen/common/src/PluginInterface.cpp
    M openmp/libomptarget/plugins-nextgen/cuda/src/rtl.cpp
    M openmp/libomptarget/plugins-nextgen/host/src/rtl.cpp

  Log Message:
  -----------
  [Libomptarget] Replace global `PluginTy::get` interface with references (#86595)

Summary:
We have a plugin singleton that implements the Plugin interface. This
then spawns separate device and kernels. Previously when these needed to
reach into the global singleton they would use the `PluginTy::get`
routine to get access to it. In the future we will move away from this
as the lifetime of the plugin will be handled by `libomptarget`
directly. This patch removes uses of this inside of the plugin
implementaion themselves by simply keeping a reference to the plugin
inside of the device.

The external `__tgt_rtl` functions still use the global method, but will
be removed later.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications