[all-commits] [llvm/llvm-project] 8e625d: Revert "Actually disable the module generation tes...

Eric via All-commits all-commits at lists.llvm.org
Mon Mar 25 15:15:17 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e625db1539b0b8c30b41cd587a11064243da6da
      https://github.com/llvm/llvm-project/commit/8e625db1539b0b8c30b41cd587a11064243da6da
  Author: Eric <eric at efcs.ca>
  Date:   2024-03-25 (Mon, 25 Mar 2024)

  Changed paths:

  Log Message:
  -----------
  Revert "Actually disable the module generation tests." (#84527)

This reverts commit 0bbada93a559b604797fe57978f3eca5e41edaeb.

The update of Clang in the CI broke due to the new LLVM version naming.
It needs to look for the clang 18.1 package instead of 18. Since it
couldn't find 18 it used 17 as fallback. This gives ODR violations which
caused the output for the module test to be wrong. (It didn't crash
which would be a lot more obvious to debug.)

The clang-tidy selection was fixed by
https://github.com/llvm/llvm-project/pull/81362. That patch also makes
clang-19 work with clang-tidy-19 out of the box.

The time-out have not been addressed; that is a CI issue and not an
issue with this test. They run in 200-ish s so they are slow but far
below the 1500s threshold. (Due to a dependency in this test it can't be
split in multiple tests.)



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list