[all-commits] [llvm/llvm-project] 3c4adb: [mlir][SCF][NFC] `ValueBoundsConstraintSet`: Simpl...

Matthias Springer via All-commits all-commits at lists.llvm.org
Fri Mar 22 23:04:40 PDT 2024


  Branch: refs/heads/users/matthias-springer/value_bounds_scf_for
  Home:   https://github.com/llvm/llvm-project
  Commit: 3c4adb5458f054634d51e1502736bb3dbebad106
      https://github.com/llvm/llvm-project/commit/3c4adb5458f054634d51e1502736bb3dbebad106
  Author: Matthias Springer <springerm at google.com>
  Date:   2024-03-23 (Sat, 23 Mar 2024)

  Changed paths:
    M mlir/lib/Dialect/SCF/IR/ValueBoundsOpInterfaceImpl.cpp

  Log Message:
  -----------
  [mlir][SCF][NFC] `ValueBoundsConstraintSet`: Simplify `scf.for` implementation

This commit simplifies the implementation of the `ValueBoundsOpInterface` for `scf.for` based on the newly added `ValueBoundsConstraintSet::compare` API and adds additional documentation.

Previously, the interface implementation created a new constraint set just to check if the yielded value and iter_arg are equal. This was inefficient because constraints were added multiple times (to two different constraint sets) for ops that are inside the loop.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list