[all-commits] [llvm/llvm-project] 8612fa: [MLIR][OpenMP] Refactor bounds offsetting and fix ...

[agozillon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8612fa0d84c730a753d04de012a8372ba5a10677
      https://github.com/llvm/llvm-project/commit/8612fa0d84c730a753d04de012a8372ba5a10677
  Author: agozillon <Andrew.Gozillon at amd.com>
  Date:   2024-03-22 (Fri, 22 Mar 2024)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/omptarget-fortran-allocatable-types-host.mlir
    M mlir/test/Target/LLVMIR/omptarget-llvm.mlir
    A openmp/libomptarget/test/offloading/fortran/target-map-enter-exit-array-2.f90
    A openmp/libomptarget/test/offloading/fortran/target-map-enter-exit-array-bounds.f90
    A openmp/libomptarget/test/offloading/fortran/target-map-enter-exit-scalar.f90

  Log Message:
  -----------
  [MLIR][OpenMP] Refactor bounds offsetting and fix to apply to all directives (#84349)

This PR refactors bounds offsetting by combining the two differing
implementations (one applying to initial derived type member map
implementation for descriptors and the other for regular arrays,
effectively allocatable array vs regular array in fortran) now that it's
a little simpler to do.

The PR also moves the utilization of createAlteredByCaptureMap into
genMapInfoOp, where it will be correctly applied to all MapInfoData,
appropriately offsetting and altering Pointer data set in the kernel
argument structure on the host. This primarily means bounds offsets will
now correctly apply to enter/exit/update map clauses as opposed to just
the Target directive that is currently the case. A few fortran runtime
tests have been added to verify this new behavior.

This PR depends on: https://github.com/llvm/llvm-project/pull/84328 and
is an extraction of the larger derived type member map PR stack (so a
requirement for it to land).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications