[all-commits] [llvm/llvm-project] 50801f: Reapply [libcxx] [modules] Fix relative paths with...

[Martin Storsjö via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 50801f1095d33e712c3a51fdeef82569bd09007f
      https://github.com/llvm/llvm-project/commit/50801f1095d33e712c3a51fdeef82569bd09007f
  Author: Martin Storsjö <martin at martin.st>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M libcxx/modules/CMakeLists.txt

  Log Message:
  -----------
  Reapply [libcxx] [modules] Fix relative paths with absolute LIBCXX_INSTALL_MODULES_DIR (#86020)

This reapplies 272d1b44efdedb68c194970a610f0ca1b7b769c5 (from #85756),
which was reverted in
407937036fa7640f61f225474b1ea6623a40dbdd.

In the previous attempt, empty CMAKE_INSTALL_PREFIX was handled by
quoting them, in d209d1340b99d4fbd325dffb5e13b757ab8264ea. That made the
calls to cmake_path(ABSOLUTE_PATH) succeed, but the output paths of that
weren't actually absolute, which was required by file(RELATIVE_PATH).

Avoid this issue by constructing a non-empty base directory variable
to use for calculating the relative path.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications