[all-commits] [llvm/llvm-project] ccb3a8: [AMDGPU][LowerModuleLDS] Refactor partially lowere...

[Pierre van Houtryve via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ccb3a8feaa5b132dc829e55e069dde62008df4a8
      https://github.com/llvm/llvm-project/commit/ccb3a8feaa5b132dc829e55e069dde62008df4a8
  Author: Pierre van Houtryve <pierre.vanhoutryve at amd.com>
  Date:   2024-03-21 (Thu, 21 Mar 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp
    A llvm/test/CodeGen/AMDGPU/lds-mixed-absolute-addresses-unused.ll
    M llvm/test/CodeGen/AMDGPU/lds-reject-mixed-absolute-addresses.ll

  Log Message:
  -----------
  [AMDGPU][LowerModuleLDS] Refactor partially lowered module detection (#85793)

Refactor the logic that checks if a module contains mixed
absolute/non-lowered LDS GVs.

The check now happens latter when the "worklists" are formed. This is
because in some cases (OpenMP) we can have non-lowered GVs in a lowered
module, and this is normal because those GVs are just unused and removed
from the list at some point before the end of `getUsesOfLDSByFunction`.

Doing the check later ensures that if a mixed module is spotted, then
it's a _real_ mixed module that needs rejection, not a module containing
an intentionally ignored GV.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications