[all-commits] [llvm/llvm-project] 5fb279: [GOFF][z/OS] Change PrivateGlobalPrefix and Privat...

[Neumann Hon via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fb2797f23343999cace3afe24480e8711df4566
      https://github.com/llvm/llvm-project/commit/5fb2797f23343999cace3afe24480e8711df4566
  Author: Neumann Hon <neumann.hon at ibm.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M clang/test/CodeGen/SystemZ/systemz-ppa2.c
    M llvm/include/llvm/IR/DataLayout.h
    M llvm/lib/MC/MCAsmInfoGOFF.cpp
    M llvm/test/CodeGen/SystemZ/call-zos-01.ll
    M llvm/test/CodeGen/SystemZ/call-zos-i128.ll
    M llvm/test/CodeGen/SystemZ/call-zos-vararg.ll
    M llvm/test/CodeGen/SystemZ/zos-ada-relocations.ll
    M llvm/test/CodeGen/SystemZ/zos-landingpad.ll
    M llvm/test/CodeGen/SystemZ/zos-ppa2.ll
    M llvm/test/CodeGen/SystemZ/zos-prologue-epilog.ll
    M llvm/test/MC/GOFF/ppa1.ll
    M llvm/unittests/IR/ManglerTest.cpp

  Log Message:
  -----------
  [GOFF][z/OS] Change PrivateGlobalPrefix and PrivateLabelPrefix to be L# (#85730)

The current values for PrivateGlobalPrefix and PrivateLabelPrefix (@@
and @ respectively) are, in hindsight, poor choices for multiple
reasons:

First, there exist externally visible routines from the language
environment that begin with @@. These functions are certainly not
local/private by any means and they should not share a prefix with
private globals.

Secondly, both private globals and private labels should be handled the
same way by GOFF, so it doesn't make much sense for them to have
separate prefixes. GOFF remains the only file format where these are
different and there is no reason for that to be the case



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications