[all-commits] [llvm/llvm-project] 123296: [lldb] Omit --show-globals in `help target var` (#...

Felipe de Azevedo Piovezan via All-commits all-commits at lists.llvm.org
Wed Mar 20 07:03:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 12329648e2c3f8651228f17d3619b1e1ddab80f0
      https://github.com/llvm/llvm-project/commit/12329648e2c3f8651228f17d3619b1e1ddab80f0
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2024-03-20 (Wed, 20 Mar 2024)

  Changed paths:
    M lldb/source/Interpreter/OptionGroupVariable.cpp
    M lldb/test/API/functionalities/target_var/TestTargetVar.py

  Log Message:
  -----------
  [lldb] Omit --show-globals in `help target var` (#85855)

This option doesn't exist. It is currently displayed by `help target
var` due to a bug introduced by 41ae8e7445 in 2018.

Some code for `target var` and `frame var` is shared, and some hard-code
constants are used in order to filter out options that belong only to
`frame var`. However, the aforementioned commit failed to update these
constants properly. This patch addresses the issue by having a _single_
place where the filtering of options needs to be done.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list