[all-commits] [llvm/llvm-project] a4b236: [mlir] Don't assert when simplifying certain `Affi...

[Felix Schneider via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a4b23638d23d603001c19285a7c7535a8ce81317
      https://github.com/llvm/llvm-project/commit/a4b23638d23d603001c19285a7c7535a8ce81317
  Author: Felix Schneider <fx.schn at gmail.com>
  Date:   2024-03-19 (Tue, 19 Mar 2024)

  Changed paths:
    M mlir/lib/IR/AffineExpr.cpp
    A mlir/unittests/IR/AffineExprTest.cpp
    M mlir/unittests/IR/CMakeLists.txt

  Log Message:
  -----------
  [mlir] Don't assert when simplifying certain `AffineExpr`s (#78855)

Currently, `simplifyMul()` asserts that either `lhs` or `rhs` is
symbolic or constant. This method is called by the overloaded `*`
operator for `AffineExpr`s which leads to a crash when building a
multiplication expression where neither operand is symbolic or constant.
This patch returns a `nullptr` from `simplifyMul()` to signal that the
expression could not be simplified instead.

Fix https://github.com/llvm/llvm-project/issues/75770



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications