[all-commits] [llvm/llvm-project] ff63d6: [CodeExtractor] Terminate callsite blocks to new `...

[goldsteinn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ff63d628c46459437df21e09f70993685eba4bc3
      https://github.com/llvm/llvm-project/commit/ff63d628c46459437df21e09f70993685eba4bc3
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M llvm/lib/Transforms/Utils/CodeExtractor.cpp
    M llvm/test/Transforms/HotColdSplit/outline-disjoint-diamonds.ll
    M llvm/test/Transforms/IROutliner/outlining-no-return-functions.ll
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.generated.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.nogenerated.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.nogenerated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.generated.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.nogenerated.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.nogenerated.globals.expected

  Log Message:
  -----------
  [CodeExtractor] Terminate callsite blocks to new `noreturn` functions with `unreachable`

Since some of the users of `CodeExtractor` like `HotColdSplitting` run
late in the pipeline, returns are not cleaned to `unreachable`. So,
just emit `unreachable` directly if the function is `noreturn`.

Closes #84682


  Commit: 6984ba7b94e13694caeea6a8dada9f79b2cc644a
      https://github.com/llvm/llvm-project/commit/6984ba7b94e13694caeea6a8dada9f79b2cc644a
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M llvm/test/Transforms/InstSimplify/floating-point-arithmetic.ll

  Log Message:
  -----------
  [InstSimply] Add tests for simplify `(fmul -x, +/-0)`; NFC


  Commit: 5265be11b1bbf5d744cf564dce91e789e2ab4c9e
      https://github.com/llvm/llvm-project/commit/5265be11b1bbf5d744cf564dce91e789e2ab4c9e
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2024-03-18 (Mon, 18 Mar 2024)

  Changed paths:
    M llvm/lib/Analysis/InstructionSimplify.cpp
    M llvm/test/Transforms/InstSimplify/floating-point-arithmetic.ll

  Log Message:
  -----------
  [InstSimply] Simplify `(fmul -x, +/-0)` -> `-/+0`

We already handle the `+x` case, and noticed it was missing in the bug
affecting #82555

Proofs: https://alive2.llvm.org/ce/z/WUSvmV

Closes #85345


Compare: https://github.com/llvm/llvm-project/compare/9936ac308332...5265be11b1bb

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications