[all-commits] [llvm/llvm-project] fce046: [mlir][bazel] Move InliningUtils into a separate t...

[Christian Sigg via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fce046ca5b7edb4c0d37a6eb580154ccb7dda966
      https://github.com/llvm/llvm-project/commit/fce046ca5b7edb4c0d37a6eb580154ccb7dda966
  Author: Christian Sigg <chsigg at users.noreply.github.com>
  Date:   2024-03-16 (Sat, 16 Mar 2024)

  Changed paths:
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
    M utils/bazel/llvm-project-overlay/mlir/test/BUILD.bazel

  Log Message:
  -----------
  [mlir][bazel] Move InliningUtils into a separate target. (#85411)

Various (in-tree as well as downstream) targets currently depend on
`InliningUtils.h` to avoid circular dependencies. E.g. `TransformUtils`
depends on `ArithDialect`, so `ArithDialect` can't depend on
`TransformUtils` exporting `InliningUtils.h`. This change exposes that
header and it's implementation as a separate target. Having targets that
implement all the declared functions is the preferred approach for bazel
build graphs.

See also PR #84878, which moves the interface definitions to a separate
file in the `Interfaces` directory. This turned out to be controversial
and putting it in a different directory didn't seem to have any support
either. Instead, this PR only changes the bazel build without moving any
C++ code.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications