[all-commits] [llvm/llvm-project] 0c9431: [MLIR][Mem2Reg] Replace pattern based approach wit...

Christian Ulmann via All-commits all-commits at lists.llvm.org
Fri Mar 15 09:46:33 PDT 2024


  Branch: refs/heads/users/dinistro/turn-mem2reg-back-to-pass
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c9431168afa054a5d9d493582687e332969dc8a
      https://github.com/llvm/llvm-project/commit/0c9431168afa054a5d9d493582687e332969dc8a
  Author: Christian Ulmann <christian.ulmann at nextsilicon.com>
  Date:   2024-03-15 (Fri, 15 Mar 2024)

  Changed paths:
    M mlir/include/mlir/Transforms/Mem2Reg.h
    M mlir/lib/Transforms/Mem2Reg.cpp
    M mlir/test/Dialect/LLVMIR/mem2reg-intrinsics.mlir

  Log Message:
  -----------
  [MLIR][Mem2Reg] Replace pattern based approach with a one-shot pass

This commit changes MLIR's Mem2Reg implementation back from being
pattern based into a full pass. Using Mem2Reg as a pattern is
wasteful, as each application can invalidate the dominance info.
Applying changes in bulk allows for reuse of the same dominance info.

Unfortunately, this requires some test changes, due to the `IRBuilder`
not simplifying IR.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list