[all-commits] [llvm/llvm-project] bba790: [BOLT] Refactor instruction creation interface. NF...

[Maksim Panchenko via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bba790db477b5b076e587b6c679ac68eb8316ac3
      https://github.com/llvm/llvm-project/commit/bba790db477b5b076e587b6c679ac68eb8316ac3
  Author: Maksim Panchenko <maks at fb.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M bolt/include/bolt/Core/MCPlusBuilder.h
    M bolt/lib/Passes/BinaryPasses.cpp
    M bolt/lib/Passes/ShrinkWrapping.cpp
    M bolt/lib/Target/AArch64/AArch64MCPlusBuilder.cpp
    M bolt/lib/Target/RISCV/RISCVMCPlusBuilder.cpp
    M bolt/lib/Target/X86/X86MCPlusBuilder.cpp
    M bolt/unittests/Core/MCPlusBuilder.cpp

  Log Message:
  -----------
  [BOLT] Refactor instruction creation interface. NFCI (#85292)

Refactor MCPlusBuilder's create{Instruction}() functions that used to
return bool. We almost never check the return value as we rely on
llvm_unreachable() to detect unimplemented functionality. There were a
couple of cases that checked the return value, but they would hit the
unreachable condition first (at least in debug builds) before the return
value gets checked.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications