[all-commits] [llvm/llvm-project] b6193a: libclc: clspv: update gen_convert.cl for clspv (#6...

Romaric Jodin via All-commits all-commits at lists.llvm.org
Thu Mar 14 12:56:55 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b6193a2dc2c7e1fb278161873e8f01f728412f4b
      https://github.com/llvm/llvm-project/commit/b6193a2dc2c7e1fb278161873e8f01f728412f4b
  Author: Romaric Jodin <89833130+rjodinchr at users.noreply.github.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M libclc/CMakeLists.txt
    M libclc/generic/lib/gen_convert.py

  Log Message:
  -----------
  libclc: clspv: update gen_convert.cl for clspv (#66902)

Add a clspv switch in gen_convert.cl
This is needed as Vulkan SPIR-V does not respect the assumptions
needed to have the generic convert.cl compliant on many platforms.

It is needed because of the conversion of TYPE_MAX and
TYPE_MIN. Depending on the platform the behaviour can vary, but most
of them just do not convert correctly those 2 values.

Because of that, we also need to avoid having explicit function for
simple conversions because it allows llvm to optimise the code, thus
removing some of the added checks that are in fact needed.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list