[all-commits] [llvm/llvm-project] 52557b: [lldb] [Mach-O] ProcessMachCore needs to strip TBI...

[Jason Molenda via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 52557bce73f64df5da13d42dd97b57fbd4ab1b12
      https://github.com/llvm/llvm-project/commit/52557bce73f64df5da13d42dd97b57fbd4ab1b12
  Author: Jason Molenda <jmolenda at apple.com>
  Date:   2024-03-14 (Thu, 14 Mar 2024)

  Changed paths:
    M lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp
    A lldb/test/API/macosx/tbi-honored/Makefile
    A lldb/test/API/macosx/tbi-honored/TestTBIHonored.py
    A lldb/test/API/macosx/tbi-honored/main.c

  Log Message:
  -----------
  [lldb] [Mach-O] ProcessMachCore needs to strip TBI data from addrs (#84998)

Darwin AArch64 application processors are run with Top Byte Ignore mode
enabled so metadata may be stored in the top byte, it needs to be
ignored when reading/writing memory. David Spickett handled this already
in the base class Process::ReadMemory but ProcessMachCore overrides that
method (to avoid the memory cache) and did not pick up the same change.
I add a test case that creates a pointer with metadata in the top byte
and dereferences it with a live process and with a corefile.

rdar://123784501



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications