[all-commits] [llvm/llvm-project] 2cae13: [DominanceFrontierBase] Fix doc of compare()'s re...

bvlgah via All-commits all-commits at lists.llvm.org
Tue Mar 12 07:46:41 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2cae13d60590c999c37828d709ff4ba58e5f261b
      https://github.com/llvm/llvm-project/commit/2cae13d60590c999c37828d709ff4ba58e5f261b
  Author: bvlgah <octopus.busts_0w at icloud.com>
  Date:   2024-03-12 (Tue, 12 Mar 2024)

  Changed paths:
    M llvm/include/llvm/Analysis/DominanceFrontier.h

  Log Message:
  -----------
  [DominanceFrontierBase] Fix doc of compare()'s  return value. (#81352)

This is a trivial fix ( I guess it has not been noticed because of no
use). Currently, the doc says the function returns `true` if two
instances of `DominanceFrontierBase` matches, otherwise `false` is
returned. I have checked the implementation


https://github.com/llvm/llvm-project/blob/9308d6688c673606fee1625d777a52539ae72015/llvm/include/llvm/Analysis/DominanceFrontierImpl.h#L71-L94

which examines whether two dominance frontier mappings are equal, and
the actual value it returns contradicts the description in the doc.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list